589 Commits

Author SHA1 Message Date
Jo-Philipp Wich
4a6927fa67 luci-theme-bootstrap: various tweaks and cleanups
- introduce new variable --text-color-highest which results in #000/#fff
   for bright and dark modes respectively
 - drop unused navigation style rules and selectors
 - use sticky positioning for header bar and drop top margin hacks
 - use flex box layout for header bar contents
 - use uniform line-height for button elements instead of pixel paddings
 - fix too bright .cbi-value bottom border in mobile dark mode
 - avoid rendering duplicate .cbi-value bottom borders for nested sections
 - simplify header markup, get rid of unused container elements
 - use non-wrapping flex box layout for page actions, prioritize primary
   action button in automatic width calculation
 - fix border radius of ifacebox headers
 - use brightest color for log output textareas
 - fix dark mode colors for mode menu
 - use flex layout for footer

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 588e24f9ca68de074c4d085ec99fd8c96ad0a3ed)
2021-10-22 20:37:12 +02:00
Jo-Philipp Wich
92ae018d61 luci-theme-bootstrap: rework uci changelog styling
Fixes: #5405
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 72d13da94cbbaab8ed3fd32f5347e7e718d46465)
2021-10-22 20:36:18 +02:00
Teoh Han Hui
83e19dcda6 luci-theme-bootstrap: add dark theme variant
Add a dark theme variant which is enabled by default when
prefers-color-scheme is set to dark.

Signed-off-by: Teoh Han Hui <teohhanhui@gmail.com>
(cherry picked from commit 6dd71eaebeb44df321c8c39da916082a0cde3285)
2021-10-22 20:36:12 +02:00
Petr Štetiar
f9e9fcff9c luci-theme-openwrt-2020: add styling of hyperlinks
Currently it's not possible to distinguish between normal text and
hyperlink.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit 60fbadfa36f9b99a536fe29482960b7f48838bd1)
2021-10-22 20:36:01 +02:00
Petr Štetiar
0ef4b2f1b3 luci-theme-openwrt-2020: add styling of abbreviations and acronyms
Style abbreviations and acronyms with dotted underline text-decoration
as without the style it's quite hard to find out which text is
abbreviation or acronym.

References: https://developer.mozilla.org/en-US/docs/Archive/Web_Standards/Styling_Abbreviations_and_Acronyms
Signed-off-by: Petr Štetiar <ynezz@true.cz>
(cherry picked from commit b5faba12442529d282668268aee0d54bd98f1419)
2021-10-22 20:35:48 +02:00
Ansuel Smith
fc702bcbf5 luci-theme-material: fix cut syslog
Remove line-height css for syslog textarea as it cause some
problem with displaying all the rows of the syslog.
(Row line are calculated with a line-height of 1)

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit a9ff8d34687b0bcec4e7766576da3b4cb3feda67)
2021-10-22 20:34:48 +02:00
Ansuel Smith
1300f4df4a luci-theme-material: improve support for dashboard module
Fix sidebar styling to improve support for dashboard module.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit 78de736a95d7eab0ccbd9753efc516dfc0e4a995)
2021-10-22 20:34:42 +02:00
Ansuel Smith
9d2c8cb429 luci-theme-material: add support for modmenu
Improve support for modmenu.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit 05d100442bbdb18c57a768abddad3221a3fd22a0)
2021-10-22 20:34:03 +02:00
Ansuel Smith
bec2c7e2b5 luci-theme-material: standardize menu and drop jquery
- Drop jquery lib
- Move to the new menu.js implementation
- Rework css to mimic old js transition
- Rework footer and header to new implementation

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
(cherry picked from commit 031424c0d31b726d445bbb824373661ca1b9a905)
2021-10-22 20:33:34 +02:00
Fritz D. Ansel
55a9f9516f theme openwrt-2020: set maximum menu width
more space for it does not have an advance

Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
(cherry picked from commit b2bea345863ed1592bd2b51f87ca0716e6fb2450)
2021-10-22 20:33:29 +02:00
Fritz D. Ansel
7ef76bcf6f theme openwrt-2020: larger bridge-boxes
they are to small for devices like e8450
as it has 4x LAN + 2x WLAN + 1x Bridge

Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
(cherry picked from commit c592ef4f8401e16959086f0f6f04c71dfba6dffa)
2021-10-22 20:33:24 +02:00
Jo-Philipp Wich
137ede6354 luci-theme-openwrt: add success style for alert messages
Fixes: #5427
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 1c3b32dc1bec15e3076a447762b1c4f94eb75fb7)
2021-10-12 23:05:29 +02:00
Florian Eckert
678ee038c0 luci-theme-openwrt-2020: add css success label
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit a655389032b85b12ec56733c455abaac07693f56)
2021-08-31 08:52:10 +02:00
Jo-Philipp Wich
ecc58e7fcb luci-theme-openwrt-2020: fix spinning disk animation
Fixes: #4824
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit e8a6f0bb7c7c24f31ddbc36f81fa97b3a2a53b2e)
2021-06-21 12:06:44 +02:00
Jo-Philipp Wich
bd36169e8c luci-theme-bootstrap: mobile style fixes for vlan filter matrix
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit e6a2cdbdab83f8eaefeec36ad668468ea374d471)
2021-06-13 21:50:18 +02:00
Jo-Philipp Wich
2afd4b78c8 luci-theme-openwrt-2020: rework table styles
Target table, tr, th and td tags directly and stop using the corresponding
CSS class names.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 70571084004ede442e7f2e944d17156c83182a24)
2021-06-12 20:01:58 +02:00
Jo-Philipp Wich
1818ddcac3 luci-theme-bootstrap: add svg help icon to form field descriptions
The still referenced help.gif icon is absent by default since it has been
moved to luci-compat.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 69608199973651baf585d24a095edf8c0c42e21f)
2021-06-12 19:23:01 +02:00
Sven Roederer
904fb39c31 luci-theme-openwrt-2020: use SVG-file for favicon and logo
Using the scalable graphic in place of the static png file saves some
ressources in flash and network. It also aligns the filetype to the type
announced to the browser.

fixes GitHub-issue #5051

Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
(cherry picked from commit 184e93df5f0365d403d4d7a6243286cbe5b914de)
2021-06-12 19:22:37 +02:00
Jan Breuer
87daaa24c8 luci-theme-openwrt-2020: remove submenu margin-bottom when submenu not visible
Signed-off-by: Jan Breuer <jan.breuer@jaybee.cz>
(cherry picked from commit 2b5f78e8936b90029478bff0f70ec8333f352b7a)
2021-06-12 19:21:24 +02:00
Hauke Mehrtens
139edfce8b themes: Call striptags() on hostname to prevent XSS
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.

If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.

This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
(cherry picked from commit 5cbd79d7e31c0f0feaea2770bf102bbae7831e3c)
2021-06-09 20:53:15 +02:00
Liangbin Lian
ac0bcc2d10 luci-theme-material: fix wrong active state on common prefix node
Before fixed, if we have two nodes: 'services/ddns' and 'services/ddnsto',
click any one of they, will show they all actived.

Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
(cherry picked from commit 97d50d2c6b80805cd7e513eeafc8b62fef4ab1b6)
2021-05-26 10:09:05 +03:00
Jo-Philipp Wich
6137c9ff33 luci-theme-openwrt-2020: honor CSS definitions passed by views
Legacy Lua views might declare a global `css` variable to inject custom
styles into the template header. Support this mechanism in the OpenWrt 2020
theme as well.

Ref: https://github.com/openwrt/luci/issues/4972
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit c5ff3244e92f267e3b7410b3196615f5fec75051)
2021-04-09 14:31:06 +02:00
Florian Eckert
4c6fb6bb97 luci-theme-openwrt-2020: add missing css success color
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
(cherry picked from commit e0c0e468e64e9b425784650c23a894b8a0f4d407)
2021-03-12 15:03:02 +01:00
Bryan Forbes
4a00f5bd8e luci-theme-openwrt-2000: Add doctype to header
Fix table rendering in the small responsive breakpoint on Safari (which
ignores `display: block;` for `<td>` elements).

Signed-off-by: Bryan Forbes <bryan@reigndropsfall.net>
2021-02-04 14:47:43 -06:00
Hannu Nyman
db15e3f695 luci-theme-rosy: Remove BROKEN theme
The Rosy theme has been marked broken for over a year,
since 23 Dec 2019. Remove it now, so that it does not
get into the next release branch 20.xx (or 21.xx).

Reference to
https://github.com/openwrt/luci/issues/3759#issuecomment-599436159

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-12-29 14:23:13 +02:00
Dirk Brenken
6ffd1592ce luci-theme-bootstrap: fix text wrapping in buttons
* should fix #4647

Signed-off-by: Dirk Brenken <dev@brenken.org>
2020-12-27 23:02:50 -10:00
Ansuel Smith
01cefed7f0
luci-theme-material: fix bigger button for combo-box
Combobox are bigger than any other button. Align the dimension to all the other buttons.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
2020-10-30 21:34:10 +01:00
Oldřich Jedlička
b03a508c6c luci-theme-material: Fix section title padding.
After moving section title from `legend`, which was translated to `span`
with style `panel-title`, to `h3`, update also CSS style to match first
`h3` in `cbi-section`.

Signed-off-by: Oldřich Jedlička <oldium.pro@gmail.com>
2020-10-25 12:11:24 +01:00
Hannu Nyman
258e74c1c3 themes: remove deprecated reference to enabling SSH
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2020-08-16 22:19:37 +03:00
Russell Morris
400ecb08f0 luci-theme-openwrt-2020: link hostname to index page
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in OpenWrt 2020, clicking on
the hostname doesn't do anything, so just pulling the same href from Material
so the link works in this theme as well.

Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust subject, commit message]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-06-16 17:09:20 +02:00
Russell Morris
27fc7a8b4e luci-theme-bootstrap: update href for Bootstrap "brand"
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.

Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-06-16 17:09:19 +02:00
Florian Eckert
aef19bb2ef luci-theme-rosy: fix Makefile file mod
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:44:03 +02:00
Florian Eckert
0024609a00 luci-theme-material: fix Makefile file mod
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:44:03 +02:00
Florian Eckert
1b875a610f luci-theme-material: remove useless logging output
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2020-05-04 12:43:59 +02:00
Jo-Philipp Wich
97bd192c7e luci-theme-openwrt-2020: add control-group style fixes
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-05-02 23:53:03 +02:00
Jo-Philipp Wich
52486e5862 luci-theme-openwrt-2020: disabled widget style tweaks
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:36 +02:00
Jo-Philipp Wich
1ac8df2614 luci-theme-bootstrap: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
48269ade61 luci-theme-openwrt: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
a1aa0af102 luci-theme-openwrt-2020: rework menu rendering
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-16 13:30:35 +02:00
Jo-Philipp Wich
eb8eeb45de luci-theme-openwrt-2020: add styles for disabled input elements
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
d9bd5466a4 luci-theme-openwrt-2020: remove xhr_poll_status markup
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-14 17:06:34 +02:00
Jo-Philipp Wich
c591490528
Merge pull request #3819 from ptpt52/theme
set mediaurlbase only when it is the first time to be installed
2020-04-08 09:07:55 +02:00
Chen Minqiang
fc150636b9 luci-theme-*: set mediaurlbase if it is the first time to be installed
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?

To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.

This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade

Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
2020-04-03 21:44:28 +08:00
Jo-Philipp Wich
015712bba0 luci-theme-bootstrap, luci-theme-openwrt-2020: fix dynlist overflows
Fixes: #3795
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-03 13:47:00 +02:00
Jo-Philipp Wich
e2750a4970 luci-theme-openwrt-2020: properly handle invalid checkbox state
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-02 15:34:19 +02:00
Jo-Philipp Wich
5220d4f373 luci-theme-openwrt-2020: fix truncated error badges in tabs
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-04-01 18:45:18 +02:00
Jo-Philipp Wich
65a461e8a0 luci-theme-openwrt-2020: fix trailing comma in CSS
Since the trailing comma rule is combined with other selectors by CSSmin,
the resulting minified stylesheet has some unexpected margin quirks.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-31 17:05:40 +02:00
Jo-Philipp Wich
63057a08dc luci-theme-openwrt: work around cssmin bug breaking the minified CSS.
The cssmin utility incorrectly breaks up calc() expressions when
minifying rules. Avoid the problem by trimming uneeded spaces.

Fixes: #3801
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-31 15:27:13 +02:00
Jo-Philipp Wich
ccb7e4a4a7 themes: generalize indicator markup and styling
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-30 17:12:07 +02:00
Jo-Philipp Wich
cfe6771846 luci-theme-openwrt-2020: further layout tweaks
- Properly format mode menu
 - Fadeout of truncated cell labels in mobile layout
 - Limit maximum width of modal overlays

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2020-03-29 13:15:31 +02:00