BPI/luci
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

luci-app-acl: remove support for plaintext login passwords

Browse Source 
Upon reviewing the rpcd session support code, it turns out that account
definitions with plaintext password values are not supported, the password
value is treated as crypt() hash/salt in any case.

Ref: https://github.com/openwrt/luci/issues/5179
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit f74b06cb92e403fa281414d5a6bd57228858bfa7)
This commit is contained in:
Jo-Philipp Wich 2021-07-13 20:45:29 +02:00
parent 07063ae51c
commit 1d6053ecd9
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
applications/luci-app-acl/htdocs/luci-static/resources/view/system/acl.js
View File

@ -219,16 +219,13 @@ return view.extend({
o.modalonly = true;
o.value('shadow', _('Use UNIX password in /etc/shadow'));
o.value('crypted', _('Use encrypted password hash'));
o.value('plain', _('Use plain password'));
o.cfgvalue = function(section_id) {
var value = uci.get('rpcd', section_id, 'password') || '';
if (value.substring(0, 3) == '$p$')
return 'shadow';
else if (value.substring(0, 3) == '$1$' || value == null)
return 'crypted';
else
return 'plain';
return 'crypted';
};
o.write = function() {};
@ -249,7 +246,6 @@ return view.extend({
o.password = true;
o.rmempty = false;
o.depends('_variant', 'crypted');
o.depends('_variant', 'plain');
o.cfgvalue = function(section_id) {
var value = uci.get('rpcd', section_id, 'password') || '';
return (value.substring(0, 3) == '$p$') ? '' : value;