BPI/luci
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

luci-app-statistics: stat-genconfig: don't emit bools for absent uci options

Browse Source 
Do not emit native collectd.conf boolean false options if the corresponding
uci option is unset in order to honour collectd's implicit defaults.

This fixes certain options, such as the memory plugins `ValuesAbsolute`,
being without effect if declared as default-enabled in the related plugin
uci forms.

Fixes: #5777
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit f16037cec5e3f65cffe2f5788c264f1912435b0e)
This commit is contained in:
Jo-Philipp Wich 2022-04-25 20:55:02 +02:00
parent fe09ab9902
commit 0473e99fab
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
applications/luci-app-statistics/root/usr/bin/stat-genconfig
View File

@ -235,13 +235,13 @@ function _bool( s, n, nopad )
local pad = ""
if not nopad then pad = "\t" end
if s and s == "1" then
str = pad .. n .. " true"
else
str = pad .. n .. " false"
if s == "1" then
str = pad .. n .. " true\n"
elseif s == "0" then
str = pad .. n .. " false\n"
end
return str .. "\n"
return str
end
function _string( s, n, nopad )